docs(discover): fix stale directory-scoped model tag examples#158
Merged
Conversation
Colon-separated tags (e.g. dummy2:dummy_2) are parsed as model name plus extra script args, not directory scope. Directory-scoped selection uses scope/tag syntax (e.g. dummy2/model1) since #109. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
coketaste
requested review from
Cemberk,
Rohan138,
gargrahul and
leconcio
as code owners
July 15, 2026 20:40
There was a problem hiding this comment.
Pull request overview
Updates documentation to reflect the current madengine discover --tags syntax for directory-scoped discovery and dynamic model parameter passing, replacing an older colon-based example that no longer matches the implementation.
Changes:
- Replace stale
dummy2:dummy_2examples with scoped-tag examples using{dir}/{model_or_tag}(e.g.dummy2/model1). - Clarify dynamic model extra-args syntax as suffix segments after
:(e.g.dummy3/model3:batch_size=512). - Apply the updates consistently across the README and CLI/usage docs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updates model discovery examples to use {dir}/{model_or_tag} scoped tags and : for extra args. |
| docs/usage.md | Clarifies directory-scoped selection and extra-args-after-: syntax with corrected examples. |
| docs/cli-reference.md | Aligns CLI reference examples with the current scoped tag and extra-args formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/usage.md — the old dummy2:dummy_2 colon syntax was stale and didn't match the actual {dir}/{model_or_tag} scoped-tag format.
Test plan